forked from 0xPolygon/polygon-edge
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: test network long blocks #29
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atanmarko
requested review from
Freyskeyd,
gruberb,
foo0x29a and
sebastiendan
September 13, 2023 08:30
4 tasks
@atanmarko Why don't we use an env var to dynamically set the block time as we do with other fields, then we don't need an extra init.sh command and we can still set 2s as the default block time. |
atanmarko
force-pushed
the
feat/test-network-long-blocks
branch
from
September 15, 2023 11:15
dbf1f37
to
b05a3fe
Compare
sebastiendan
approved these changes
Sep 15, 2023
gruberb
approved these changes
Sep 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
atanmarko
added a commit
that referenced
this pull request
Sep 15, 2023
atanmarko
added a commit
that referenced
this pull request
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added option for custom block time when starting Polygon Edge,
BLOCK_TIME
. Default is 2 secods.Changes include
Checklist
Testing